Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use phpstan-codeigniter #7923

Merged
merged 1 commit into from
Sep 11, 2023
Merged

chore: use phpstan-codeigniter #7923

merged 1 commit into from
Sep 11, 2023

Conversation

paulbalandan
Copy link
Member

Description
Add phpstan-codeigniter

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan force-pushed the phpstan-codeigniter branch 3 times, most recently from 044e08f to 5b52c95 Compare September 11, 2023 07:57
@paulbalandan
Copy link
Member Author

@samsonasik is there a way to tell rector to read the GeneratedConfig of phpstan/extension-installer? Or do I need to write all extensions' configs in $rectorConfig->phpstanConfigs()?

@samsonasik
Copy link
Member

@paulbalandan we had it automatically, but removed due to possible magic use cases on auto include, the :

$rectorConfig->phpstanConfigs(...);

seems the way to go.

kenjis
kenjis approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kenjis kenjis merged commit b6ecf0b into codeigniter4:develop Sep 11, 2023
@kenjis
Copy link
Member

kenjis commented Sep 11, 2023

@paulbalandan Thank you!

@paulbalandan paulbalandan deleted the phpstan-codeigniter branch September 12, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @samsonasik @kenjis